fix(dashboard): keep polling paused runs so the 2nd approval gate appears#357
Merged
Conversation
…urfaces A workflow run pauses at each human-approval gate. The run-detail poller only rescheduled for 'running'/'pending', so it stopped the moment the run paused at gate 1. After approving gate 1 the run advances and pauses again at gate 2, but with polling already halted the second gate never appeared until a manual browser refresh. Include 'paused' in the keep-polling condition (it's an in-flight state). Unrecognized statuses are still treated as terminal so we don't loop forever. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for lustrous-pasca-e9664a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The orchestrator image embeds the web dashboard (web/dist), but the deploy workflow didn't watch web/**, so dashboard-only fixes never auto-deployed. Add web/** to the push paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In a workflow with two human-approval gates, after approving the first gate the dashboard does not refresh to show the second gate's "awaiting approval" state — you have to manually refresh the browser.
Root cause
web/src/revka/pages/WorkflowRuns.tsx— the run-detail poller only reschedules itself while the run isrunningorpending:A run is
pausedwhile sitting at a human-approval gate. So polling halts at gate 1. After approval the run advances and pauses again at gate 2 — but polling already stopped, so the new gate never surfaces until a manual refresh.Fix
Include
'paused'in the keep-polling condition (it's an in-flight state). Unrecognized statuses are still treated as terminal, so we never loop forever.Found live during the Track 3 demo recording (two-gate
github-issue-resolverworkflow).Typecheck:
npm run typecheck(tsc -b) passes.🤖 Generated with Claude Code