Repository navigation
perf(ci): speed up validation without reducing coverage - #1441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up GitHub Actions without removing necessary tests or native/platform validation. The original CI-only commit was
a0afddb154758d4ae7b689629cef88647e6045b3; current integration head is3d78d0fdf5c82407530537f9bd7f2fac58f019ab. Measurements below are historical and do not certify the updated combination.This is the isolated CI-only continuation of #1440. Its shared checkout acquired unrelated ADE work during verification; that branch and draft PR were preserved. This PR contains only the CI optimization commit and its reviewed dotenv correction, touching 16 CI/build/test files and no ADE feature code.
Measured results
npm testBaseline: authenticated
ghsnapshot of the latest 50 runs at task start, comprising 130 jobs. PR Checks baseline uses the median of five complete successful runs; canceled/failed samples are excluded. The first complete optimized run also passed at 31m08s. Final local measurement used a clean, isolated Node 22.23.1 install: full build 196.330s, unchanged second build 1.081s, both exit 0. These are observed samples, not a claim that runner/cache/network variability or every individual job improved.Final PR Checks run 41327610438: 18/18 jobs successful. All 10 triggered workflows passed; 31 automatic jobs succeeded and the one existing opt-in OS credential probe remained skipped.
Changes
PR gate. Historical package wait was mostly about 39m14s ofneeds, with only 2–4s of scheduler wait.PR gate. Fail closed on API truncation, code renames, detection failures and unexpected skipped/failed code checks.cancel-in-progress: falseand GitHub's documentedqueue: max, so the default single-pending replacement does not discard stable commits.Tests and limitations
npm ci; 199 workflow contract tests, 10 build-reuse regressions, 14 Kun runner tests and 20 Settings geometry tests passed. Packaging contracts: 118 passed with one existing platform skip. Complete application build and unchanged-repeat reuse both succeeded.concurrency.queue; the field is documented by current GitHub Actions and covered by workflow contracts.Integration after #1445
Integrated actual develop merge a1d4e82, including #1445 update repair and all current pet fixes. Required Windows recovery, authentic cross-version normal/busy/rollback, candidate old-GUI pending protection and strict native finalization matrices remain required by PR gate. Same-run package/source provenance and complete script-test union are retained. Added an explicit contract guarding these integration requirements.
Independent review cleared exact tree a7bacf0564f64ea274b8cb94febb2088927c5ac5 (local b1ce5af0). Root verified uploaded tree and exact parents original a0afddb + actual develop a1d4e82. Focused CI contracts 33/33; packaging 119 passed/2 platform skips; Kun scripts 14/14; pet preview 4/4; lint, file-line and diff checks passed. Workflow suite 249/250, with one local sandbox Unix-socket EPERM failure; no test assertion removed. Independent review also ran 42 focused contracts successfully.
Fresh full CI for the integrated head is pending. Prior performance and green-check results above remain historical; this version must demonstrate all newly retained native update gates before merge. No release or deployment.
Refreshed develop integration
Head 1a009c9 passed all ten workflows, all eight GUI/Kun shards, scripts/extensions, native lease tests, packaging and genuine required pending-protection/finalization plus normal/busy/rollback (PR Checks 41487524560). Workspace Windows passed one scoped retry after its unchanged ~100ms fixture poll timed out; no assertions were weakened. Fresh native evidence artifacts: prepared 13165049105, standard 13166542597.
Before merge, develop advanced to 3c5f3ad, including an installer abort-path old-app relaunch and pet protocol/CSP updates. All 11 upstream files were integrated verbatim; the same 16-file CI optimization diff and required gates remain. Independent review cleared frozen tree 4b4d517f66b593ab39753005197b3fbe625d06d7 (local 22357cc7). 52 focused contracts and 10 focused Vitest tests passed; 4 Windows-only tests and Windows syntax were explicitly not run locally. Lint/line/diff checks passed. Because installer behavior changed, fresh full/native CI is required for this head; earlier green checks are not reused as certification.
Final integrated validation
Exact head 3d78d0f passed all ten workflows on their first attempt, including PR Checks 41497803508 and PR gate. All eight GUI/Kun shards, extension/script suites, four platform packages/handoffs and native workflows executed successfully. Fresh Windows native lease cases ran; required prepared protection/finalization and normal/busy/rollback passed with verified same-run package provenance and no cleanup errors.
Required prepared artifact: https://github.com/KunAgent/Kun/actions/runs/41497803508/artifacts/13170737441
Normal/busy/rollback artifact: https://github.com/KunAgent/Kun/actions/runs/41497803508/artifacts/13171211207
The latest validation includes the new develop installer abort behavior. Base was rechecked at 3c5f3ad before merge. This certifies the retained tests and current integrated behavior, not a fixed wall-time guarantee or resolution of the originally unreproduced #1421 stall. No release/deployment was performed.