Skip to content

chore(ci): the cyclic-resource entry covers any in-flight head material - #131

Merged
KunalSiyag merged 2 commits into
mainfrom
droid/engine-errors-cyclic-family
Oct 30, 2026
Merged

KunalSiyag merged 2 commits into
mainfrom
droid/engine-errors-cyclic-family

Conversation

@KunalSiyag

Copy link
Copy Markdown
Owner

What

#99's allowlist entry was substr-pinned to Male_Adult_15_head.tres, but the
threaded body load races whichever shared head material is in flight. Vehicles
hit Male_Adult_12_head.tres in #126's gate (fp_car_doors FAIL(engine-error))
despite a PASS suite verdict. Across recent gate logs the race has hit five
variants: Male_Adult_12/15/18, Wood_Male_01, Business_Male_07.

Fix

Match the mat/ prefix instead of one variant. One line, reason extended with
the observed variants.

Verification

  • engine_errors.py rc=0 on vehicles' failing fp_car_doors log
  • Sweep over the 4 most recent pre-reboot gate dirs: no other uncovered errors
  • pre-commit + run_all PASS, gate quick PASS (post-reboot rerun; the first
    attempt's only failure was a load-flake fp_carjack death, 0-byte FAIL-free
    log under load ~13)

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

The #99 entry was pinned to Male_Adult_15_head.tres, but the threaded
body load races whichever shared head material is in flight: gate logs
show Male_Adult_12/15/18, Wood_Male_01 and Business_Male_07. Match the
mat/ prefix instead of one variant (fp_car_doors flaked on _12 in #126's
gate).

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Automated review

No new findings on the 1 changed files (gdlint, complexity, TODO policy, dead code).

Run python3 tools/checks/run_all.py locally for the full set of checks.

@KunalSiyag
KunalSiyag merged commit d6e37bf into main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant