Repository navigation
fix(tests): fp_posters' offline-guard check forces GRIDFALL_OFFLINE itself - #140
Merged
Merged
Conversation
…tself _test_default_transport_offline asserts the client makes no network requests "under GRIDFALL_OFFLINE=1", but nothing set that env — the gate and CI export it, so they stayed green, while a bare standalone `godot -s` run without it took the live path with the default transport and failed both checks (a provisional texture, one transport call). The section now sets GRIDFALL_OFFLINE=1 itself and restores the prior value, so the check holds however the test is launched. Verified: fp_posters_test passes standalone with GRIDFALL_OFFLINE unset and with it set to 1; run_all + pre-commit green. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Automated reviewNo new findings on the 1 changed files (gdlint, complexity, TODO policy, dead code). Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main-red fix:
fp_posters_testfailed standalone on clean main withRoot cause
Not the virtual-ms pump from #125 — the env.
_test_default_transport_offlineasserts offline-guard behaviour but never setsGRIDFALL_OFFLINE; it leaned on the runner. Gate and CI exportGRIDFALL_OFFLINE=1(tools/gate.sh does it for every Godot run), so they stayed green; a baregodot --headless -s tools/tests/fp_posters_test.gdwithout it takes the live path with the default transport (fake key, live enabled) — one transport call and a provisional texture, failing both checks. Reproduced exactly on cleanorigin/main(passes with the env set, fails without).Fix
The section now forces
GRIDFALL_OFFLINE=1itself and restores the prior value after — the check names the env, so it owns it. Four lines, no production change.Verification
GRIDFALL_OFFLINE=1: PASS before and afterrun_all+pre-commitgreen (the file is gdformat-grandfathered; verified the hook passes without reformatting)Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>