Repository navigation
fix(fp): junction furniture leaves the shadow pass on the web tier - #145
Merged
Merged
Conversation
Each shadow caster is a shadow-pass draw, and a signal lens or sign face casts nothing a walker reads. On the web tier (vis_mult < 1) _range_asset now strips cast_shadow from the GLB children and the kit parts (_mi) no longer cast; the kit range also scales by vis_mult there, closing the gap fix #128 left between _mi (absolute VIS_PROP) and _range_asset (scaled). Desktop and orbit are unchanged. Sites needed nothing: their small parts already ask for shadow=false and the static merge buckets the rest, so the caster set is identical across tiers (verified by probe). Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Automated reviewNo new findings on the 3 changed files (gdlint, complexity, TODO policy, dead code). Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vis_mult < 1.0), closing the last unranged-shadow draw lane the day-10 census found._mi()'s visibility range now scales with the quality preset (VIS_PROP * vis_mult), matching_range_asset()— the two paths disagreed since fix(fp): range traffic signals and signs by view distance #128.vis_mult == 1.0): ranges and cast_shadow sets are identical there; construction sites were verified shadow-tight already by probe (small parts opt out, static merge buckets the rest).Evidence
tools/tests/fp_shadow_pass_test.gd(6/6): junction children ranged and shadow-stripped at web tier, untouched at desktop tier.Validation
tools/gate.sh quick+fullgreen (GATE_RETRIES=1) on the rebased commit.python3 -m pytest --no-cov,tools/checks/run_all.py,pre-commit run --all-filesgreen.Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>