fix: git actions misc#92
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b8f3d6210
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| volumes: | ||
| downloads: {} | ||
| shared-execution-data: | ||
| external: true |
There was a problem hiding this comment.
When users follow the documented docker compose up -d path on a fresh host or CI runner where shared-execution-data has not already been created, this default compose file now aborts before starting the server. Docker Compose documents external: true as meaning the volume already exists, Compose does not create it, and it returns an error if the volume is missing; the previous managed named volume was auto-created. Keep the default volume managed by Compose, or move this shared external volume into an opt-in override/deployment file.
Useful? React with 👍 / 👎.
| "conversions": "Conversions", | ||
| "campaign-conversion-tracking": "CampaignConversionTracking", |
There was a problem hiding this comment.
When AMAZON_AD_API_PACKAGES includes either of these newly added aliases, _load_package_allowlist resolves them directly to Conversions / CampaignConversionTracking, but the mount loop only matches actual JSON stems and a repo-wide check of openapi/resources plus dist/openapi/resources finds no corresponding Conversions.json or CampaignConversionTracking.json files (only AmazonDSPConversions.json). With just these requested packages the allowlist is non-empty while no matching spec is mounted, so the advertised packages expose no tools; map the aliases to existing stems or add the missing specs.
Useful? React with 👍 / 👎.
1 participant
No description provided.