Release 0.4.5 heartbeat, notes, and memory fixes#15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e36243ef37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| url: str, | ||
| headers: dict[str, str], | ||
| auth_profile: Optional[str] = None, | ||
| ) -> tuple[dict[str, str], dict]: |
There was a problem hiding this comment.
_apply_local_auth's dict contract
Changing this helper to return (headers, auth_context) breaks the existing release check in scripts/release_regression.py:52-78, which still treats _apply_local_auth(...) as a dict and calls .get(...) on it. That means the regression script now aborts before it can validate the 0.4.5 auth changes, so the release gate fails as soon as this path is exercised.
Useful? React with 👍 / 👎.
| sql += " ORDER BY updated_at DESC LIMIT ?" | ||
| params.append(max(1, min(int(limit or 20), 100))) | ||
| with self._connect() as conn: | ||
| rows = conn.execute(sql, tuple(params)).fetchall() | ||
| notes = [self._row_to_note(row) for row in rows] |
There was a problem hiding this comment.
When tags is provided, this query still fetches only the latest limit rows and then filters them in Python afterward. If the newest 20 notes do not carry the requested tag(s) but older notes do, notes_list_notes incorrectly returns no matches even though matching notes exist in the store.
Useful? React with 👍 / 👎.
| if self.workspace: | ||
| workspace_root = self.workspace.expanduser().resolve() | ||
| return workspace_root / token_path.lstrip("~/") |
There was a problem hiding this comment.
~/ token paths to home, not the workspace
For profiles whose bearer_token_path starts with ~/ (including the built-in Moltbook profile), this branch writes the refreshed bearer under <workspace>/.config/... instead of $HOME/.config/.... The immediate request still succeeds, but later runs in a different workspace will not see the persisted token and will keep retrying stale credentials.
Useful? React with 👍 / 👎.
1 participant
No description provided.