Skip to content

Remove logging.basicConfig() to avoid conflict with clients - #7

Open
athyuttamre wants to merge 1 commit into
Kylmakalle:mainfrom
athyuttamre:main
Open

Remove logging.basicConfig() to avoid conflict with clients#7
athyuttamre wants to merge 1 commit into
Kylmakalle:mainfrom
athyuttamre:main

Conversation

@athyuttamre

Copy link
Copy Markdown

Calling logging.basicConfig() causes duplicate logging in client code. This is because clients that import devicecheck before setting up their own log handlers will end up with two log handlers.

Here's a simple repro: https://github.com/athyuttamre/devicecheck-repro

This PR removes this line from the package.

@Kylmakalle

Copy link
Copy Markdown
Owner

I appreciate the example, even for this one line diff.

You likely want to remove the logger configuration in init.py file as well

I think the reason for this line was my internal testing where I'm not setting up the basic configuration elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants