Remove logging.basicConfig() to avoid conflict with clients - #7
Open
athyuttamre wants to merge 1 commit into
Open
Remove logging.basicConfig() to avoid conflict with clients#7athyuttamre wants to merge 1 commit into
logging.basicConfig() to avoid conflict with clients#7athyuttamre wants to merge 1 commit into
Conversation
Owner
|
I appreciate the example, even for this one line diff. You likely want to remove the logger configuration in init.py file as well I think the reason for this line was my internal testing where I'm not setting up the basic configuration elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
logging.basicConfig()causes duplicate logging in client code. This is because clients that importdevicecheckbefore setting up their own log handlers will end up with two log handlers.Here's a simple repro: https://github.com/athyuttamre/devicecheck-repro
This PR removes this line from the package.