Repository navigation
🎨 Palette: accessible form controls & keyboard focus rings - #370
nathfavour merged 1 commit into
Conversation
- Add explicit aria-label attributes to icon-only buttons in FormDialog (remove question, remove choice option, Kylrix Assist launcher, main close button, ghost fields drawer close, field rules drawer close). - Configure switch semantics (role="switch", aria-checked, descriptive aria-label) on required and submission limit toggles. - Add keyboard focus rings (focus-visible:ring-2 focus-visible:ring-[#6366F1] and focus-visible:ring-red-400). - Add unit test suite in components/forms/FormDialog.test.tsx. Co-authored-by: nathfavour <116535483+nathfavour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added accessible ARIA labels, switch semantics, and keyboard focus rings to interactive elements in
components/forms/FormDialog.tsx.🎯 Why:
Icon-only action buttons (such as delete question, delete choice option, AI auto-creator trigger, and drawer close buttons) lacked explicit accessible names for screen reader users and missing keyboard focus indicators. Additionally, toggles for "Required" and "Single response limit / Multi-submission" functioned as stateful switches without standard
role="switch"andaria-checkedattributes.♿ Accessibility:
aria-label="Remove question",aria-label="Remove option N",aria-label="Kylrix Assist — AI Auto-Creator",aria-label="Close form editor",aria-label="Close ghost fields drawer", andaria-label="Close field rules drawer".role="switch",aria-checked, descriptive labels) on question required and multi-submission toggles.focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#6366F1]/focus-visible:ring-red-400).components/forms/FormDialog.test.tsx.PR created automatically by Jules for task 10281919965511421731 started by @nathfavour