Repository navigation
🎨 Palette: accessible event details controls & focus rings - #371
nathfavour merged 1 commit into
Conversation
- Add explicit `aria-label` attributes to icon-only action buttons in `EventDetails` (close button, title save button, Sidekick companion launcher, and edit about event trigger).
- Add accessible dialog trigger semantics (`aria-haspopup="dialog"`, `aria-expanded={isVisibilityDrawerOpen}`, and descriptive `aria-label`) to event visibility control.
- Add accessible keyboard focus rings (`focus-visible:ring-2 focus-visible:ring-[#6366F1]` / `focus-visible:ring-[#F59E0B]`) to all interactive actions.
- Add unit test in `components/events/EventDetails.test.tsx`.
Co-authored-by: nathfavour <116535483+nathfavour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added micro-UX accessibility enhancements across interactive controls in
EventDetails.tsx:aria-labelattributes for icon-only action buttons (close button, title save button, Sidekick companion launcher, and edit about event trigger).aria-haspopup="dialog",aria-expanded={isVisibilityDrawerOpen}, and descriptive dynamicaria-label).focus-visible:ring-2 focus-visible:ring-[#6366F1]andfocus-visible:ring-[#F59E0B]) across interactive controls to support keyboard-only users.🎯 Why:
Screen readers could not meaningfully announce the intent of icon-only action buttons without labels or popup semantics for drawer triggers. In addition, keyboard users navigating with Tab lacked prominent focus indicators on several buttons.
♿ Accessibility:
aria-labelattributes on icon-only buttonsaria-haspopup="dialog"andaria-expandedstate on visibility controlfocus-visible:ring-2keyboard focus ringscomponents/events/EventDetails.test.tsxverifying accessibility contract invariantsPR created automatically by Jules for task 14542453181935597903 started by @nathfavour