Repository navigation
π‘οΈ Sentinel: [HIGH] Harden Discord webhook URL validation - #372
Conversation
Co-authored-by: nathfavour <116535483+nathfavour@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability:
isValidDiscordWebhookUrlinapp/api/discord/route.tspermitted arbitrary non-standard ports (enabling internal port scanning), userinfo credentials (user:pass@, enabling credential smuggling), and loose path matching (allowing traversal and invalid resource endpoints).π― Impact: Attackers or compromised bots could use webhook dispatch to perform internal port probing or leak credentials in outbound requests.
π§ Fix: Enforce standard port 443, reject userinfo, and validate the path against
/^\/api\/webhooks\/\d{15,21}\/[\w-]{20,100}\/?$/.β Verification: Added comprehensive unit tests in
app/api/discord/route.test.ts, verified 35/35 tests pass, and ran full test suite and ESLint with zero errors.PR created automatically by Jules for task 2321008999710079397 started by @nathfavour