Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Harden Discord webhook URL validation - #372

Merged
nathfavour merged 1 commit into
masterfrom
sentinel/harden-discord-webhook-ssrf-3693674281527980091-2321008999710079397
Nov 8, 2026
Merged

nathfavour merged 1 commit into
masterfrom
sentinel/harden-discord-webhook-ssrf-3693674281527980091-2321008999710079397

Conversation

@nathfavour

Copy link
Copy Markdown
Member

🚨 Severity: HIGH
πŸ’‘ Vulnerability: isValidDiscordWebhookUrl in app/api/discord/route.ts permitted arbitrary non-standard ports (enabling internal port scanning), userinfo credentials (user:pass@, enabling credential smuggling), and loose path matching (allowing traversal and invalid resource endpoints).
🎯 Impact: Attackers or compromised bots could use webhook dispatch to perform internal port probing or leak credentials in outbound requests.
πŸ”§ Fix: Enforce standard port 443, reject userinfo, and validate the path against /^\/api\/webhooks\/\d{15,21}\/[\w-]{20,100}\/?$/.
βœ… Verification: Added comprehensive unit tests in app/api/discord/route.test.ts, verified 35/35 tests pass, and ran full test suite and ESLint with zero errors.


PR created automatically by Jules for task 2321008999710079397 started by @nathfavour

Co-authored-by: nathfavour <116535483+nathfavour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@nathfavour
nathfavour merged commit 215f178 into master Nov 8, 2026
4 checks passed
@nathfavour
nathfavour deleted the sentinel/harden-discord-webhook-ssrf-3693674281527980091-2321008999710079397 branch November 8, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant