Repository navigation
Build the plugin on Omarchy 4.5.0, which dropped LockFeedSurface.qml - #8
Merged
Merged
Conversation
Omarchy removed lock/LockFeedSurface.qml in 4.5.0-rc2 (2a1ff8d, #15289) and LockView no longer loads it. The 4.5 file set still required it, so no set matched on rc2, rc3 or 4.5.0 final: the post-update rebuild failed and doctor warned about drift on every run. Every 4.5 anchor still matches; only the file entry goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
tested it on the 4.5.0 sources and on 4.0.6, builds fine on both. thanks for catching this so fast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omaFace 1.2.2 cannot build its plugin on Omarchy 4.5.0 final. After
omarchy updatethe post-update rebuild fails, a notification says "1 problem(s) after the update. Run: omaface doctor", and the lock screen keeps running a copy built from older Omarchy sources:The 4.5 set still copies
lock/LockFeedSurface.qml, which Omarchy deleted after rc1. This drops that entry. Every 4.5 patch anchor still matches 4.5.0, so nothing else changes.Upstream Omarchy changes since
v4.5.0-rc1These two commits touch
shell/plugins/lockbetweenv4.5.0-rc1andv4.5.0. Nothing touchedshell/plugins/polkit.2a1ff8d(#15289), first inv4.5.0-rc2: shows a video wallpaper's still frame on the lock screen instead of playing it. It removeslock/LockFeedSurface.qml, andLockView.qmlno longer loads it. This is the break.00e4a12(#17277), first inv4.5.0: keeps the lock usable after an NVIDIA suspend's VT switch (restorePasswordFocus()inLockView.qml, a longer blank delay after resume inService.qml). No omaFace anchor is touched. The rebuilt plugin picks these fixes up.Validation
The plugin was built with
OMAFACE_UPSTREAMpointing at each source tree, then checked withomarchy plugin validate:4.5.0-3(sameService.qmlas tagv4.5.0)v4.5.0v4.5.0-rc3v4.0.6v4.0.0Service.qml,LockView.qmlandPolkit.qmlload only files that are in the plugin (FingerprintModel.js,PolkitModel.js,Settings.qml).v4.5.0-rc1is the only release that still hadLockFeedSurface.qml. On rc1 this set would build aLockView.qmlwhose feedLoaderpoints at a file the plugin does not have. rc1 is superseded by final, so I did not keep a separate set for it.Created with Claude Opus 5.5 in Claude Code.