Utilities.Crypto class using obsolete constructors and methods

[L34T]

SYSLIB0041: Constructor 'System.Security.Cryptography.Rfc2898DeriveBytes.Rfc2898DeriveBytes(string, byte[])' is obsolete: The default hash algorithm and iteration counts in Rfc2898DeriveBytes constructors are outdated and insecure. Use a constructor that accepts the hash algorithm and the number of iterations.

• ORBS/Utilities/Crypto.cs

  Line 34 in e30462c

  Rfc2898DeriveBytes key = new Rfc2898DeriveBytes(sharedSecret, _salt);

• ORBS/Utilities/Crypto.cs

  Line 95 in e30462c

  Rfc2898DeriveBytes key = new Rfc2898DeriveBytes(sharedSecret, _salt);

SYSLIB0045: Cryptographic factory methods accepting an algorithm name are obsolete. Use the parameterless Create factory method on the algorithm type instead.

• ORBS/Utilities/Crypto.cs

  Line 37 in e30462c

  aesAlg = Aes.Create("AesManaged");

• ORBS/Utilities/Crypto.cs

  Line 103 in e30462c

  aesAlg = Aes.Create("AesManaged");

[L34T]

ORBS/Model/CloudRaiding/ParselyUploader.cs

Line 40 in e30462c

content.Add(new StringContent(Crypto.DecryptStringAES(Settings.ReadSettingOfType<string>("password").Trim('"'), "parselyInfo")), "password");

Rfc2898DeriveBytes encryption seems to be solely utilized to protect the session password that is stored locally and has no external dependencies to keep using it.

The current recommendations require the replacement of the obsolete Rfc2898DeriveBytes encryption.

StarParse uses Base64 for these purposes:
https://github.com/Ixale/StarParse/blob/3051963dd50086d1d7fc4e8c5ca2eac35fc4bc0f/starparse-client/src/main/java/com/ixale/starparse/service/impl/ParselyServiceImpl.java#L46