User/michelan98/77 user profile - #156
Open
Michelan98 wants to merge 6 commits into
Open
Michelan98 wants to merge 6 commits into
Michelan98 wants to merge 6 commits into
Conversation
…nd profile info views next
…ion, error handling and input. Need to figure out passing image from profile Edit to Profile
andibakti
requested changes
Mar 9, 2020
andibakti
left a comment
andibakti
left a comment
Collaborator
There was a problem hiding this comment.
Adding the files to the manifest would probably fix the error you were getting, other than that the rest is minor
|
|
||
| import java.io.Serializable; | ||
|
|
||
| public class EditProfileInfo extends AppCompatActivity{ |
Collaborator
There was a problem hiding this comment.
You need to declare it in the manifest file too otherwise it won't run
| } | ||
|
|
||
| private void launchEditProfileInfoActivity() { | ||
| Intent intent = new Intent(this, EditProfileInfo.class); |
Collaborator
There was a problem hiding this comment.
same thing, so you probably need to change the manifest
| } | ||
|
|
||
| private void launchViewGoalsActivity(){ | ||
| Intent intent = new Intent(this, ViewGoals.class); |
| android:textAlignment="center"/> | ||
|
|
||
| <SeekBar | ||
| android:id="@+id/seekBar_updated_goal" |
Collaborator
There was a problem hiding this comment.
minor note but small text appears when moving the seek bar
| android:textColor="@color/textWhite"/> | ||
|
|
||
| <LinearLayout | ||
| android:id="@+id/popup_goal_edit" |
Collaborator
There was a problem hiding this comment.
cool way of doing this, are you readjusting the position at runtime? if so this layout should probably be invisible since it peaks out at the bottom of the screen
|
|
||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="526dp" |
Collaborator
There was a problem hiding this comment.
this can just be match_parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.