revert small change in acoustics-refactor pr#541
Open
LawrenceBorst wants to merge 1 commit into
Open
Conversation
LawrenceBorst
force-pushed
the
acoustics-revert-some-changes
branch
from
c4b966b to
f536925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a look at the old PR I made for acoustics
https://github.com/LAAC-LSCP/ChildProject/pull/535/changes
Everything looks good, including the zooniverse change, but the change on line 129 in release-tests.yml made me raise an eyebrow. I remember pushing these changes in a hurry during a plenary meeting, so not surprised if it's a mistake.