revert: "fix(e2e-tests): run e2e tests as user, not as root"#64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I discovered if you're running as root for the e2e test suite, test cleanup fails because pytest attempts to clean up after changes committed by the Docker daemon, and this gives permission denied problems—this happens if a test fails.
But then I changed it. Now there's another problem, I can't write to paths inside the container owned by a different user (see the Dockerfile chown that was recently added).
Now reverting this change... Honestly no big deal. Files are written to /tmp, and either (1) cleaned up on reboot or (2) run by ephemeral job runners that clean after themselves.
Review