ensure data folder included in wheel/sdist#556
Merged
larsoner merged 4 commits intoLABSN:mainfrom Feb 10, 2026
Merged
Conversation
larsoner
approved these changes
Feb 10, 2026
| if isinstance(obj, (Rectangle | Circle | Diamond | Triangle)): | ||
| return self._point_in_tris(pos, obj) | ||
| elif isinstance(obj, (ConcentricCircles, FixationDot)): | ||
| elif isinstance(obj, (ConcentricCircles | FixationDot)): |
Member
There was a problem hiding this comment.
If you want and you're bored (hah!), you could enable the ruff rule and let it autofix. No need to do it now but next time one of us is poking around might be a quick fix
| source = "vcs" | ||
|
|
||
| [tool.hatch.build.targets.sdist.force-include] | ||
| "expyfun/data" = "expyfun/data" |
Member
There was a problem hiding this comment.
I wonder why we don't have to do this for MNE-Python and why it differs per platform... but not enough to investigate 😄
Member
Author
There was a problem hiding this comment.
FWIW, before this PR python -m build -w on linux yields a wheel with no data folder. So probably what's going on is that it's not a platform-specific bug, and somehow I ended up with an editable install on my linux system.
Why you don't have to do it for mne is because mne/data/__init__.py exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #554