Skip to content

ENH: Add OTP processing option#356

Open
mdclarke wants to merge 37 commits intoLABSN:mainfrom
mdclarke:otp
Open

ENH: Add OTP processing option#356
mdclarke wants to merge 37 commits intoLABSN:mainfrom
mdclarke:otp

Conversation

@mdclarke
Copy link
Copy Markdown
Contributor

@mdclarke mdclarke commented Feb 4, 2022

Closes #355

Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdclarke looks like it's close! I pushed some commits to fix the CIs. CircleCI was broken and Travis wasn't running, so I fixed those. Then in terms of your changes, I had to change the order of some stuff to make the YAML match the overview.rst.

I think what's left is:

  1. Update the flowchart by changing https://github.com/LABSN/mnefun/blob/main/mnefun/_flow.py
  2. Make it so that the SSS step uses either the raw files (if otp_dur is None) or the OTP'ed files (if otp_dur is not None)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@dde46d7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage        ?   20.09%           
=======================================
  Files           ?       34           
  Lines           ?     5185           
  Branches        ?        0           
=======================================
  Hits            ?     1042           
  Misses          ?     4143           
  Partials        ?        0           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Add OTP processing option

3 participants