Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds pre-review updates to a JOSS paper for the pharmsol software package. The changes primarily expand the paper with new sections providing additional context about software design, research impact, and AI usage disclosure.
Changes:
- Added "Software design" section explaining the architecture and design principles
- Added "Research impact statement" documenting existing usage and publications
- Expanded data format section with builder-pattern information
- Added "AI usage disclosure" section declaring the use of generative AI
- Updated bibliography with a new book chapter citation
- Added
/joss/paper_filesto.gitignore
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| joss/paper.md | Added four new sections (Software design, Research impact statement, AI usage disclosure) and expanded Data format section |
| joss/paper.bib | Added bibliography entry for npod book chapter reference |
| .gitignore | Added /joss/paper_files directory to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Siel
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.