Skip to content

Fix link to repository and small formatting fixes#21

Merged
LCrossman merged 2 commits into
LCrossman:mainfrom
CGMossa:quick_fixes
Jun 3, 2025
Merged

Fix link to repository and small formatting fixes#21
LCrossman merged 2 commits into
LCrossman:mainfrom
CGMossa:quick_fixes

Conversation

@CGMossa

@CGMossa CGMossa commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Hello! Nice collection of packages.

I was just taking a look, and noticed that

  • a link to the repository is broken
  • syntax highlighting in the READMEs were missing

Thus, here is a small and quick PR

@LCrossman

Copy link
Copy Markdown
Owner

Hi @CGMossa thanks v much, this looks great!!
The thing about the link to the crates.io was that I in fact merged the microSeqIO into the main microBioRust to make import paths shorter and create a flatter structure. But we could review that structure again if there's broader interest in keeping it separate or better modularity?
In the current case could you mind splitting this PR into 2 - one for the crate/module restructure and one for the general improvements? Then I can merge the general improvements straightaway.

@CGMossa

CGMossa commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

Sure. Just to make sure we understand each other. Do you know, that the link currently present leads nowhere?

@LCrossman

Copy link
Copy Markdown
Owner

Hi, Ah I get you now! Thanks, yes I yanked that microSeqIO so as to make a simpler structure.
microBioRust-microSeqIO v0.1.1 Yanked.
So let me accept your PR as it is :) & consider later the structure with IO.

@LCrossman LCrossman left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LCrossman
LCrossman merged commit 554617a into LCrossman:main Jun 3, 2025
1 check passed
@CGMossa
CGMossa deleted the quick_fixes branch June 3, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants