Repository navigation
feat: Java LSP flavored IDE - #12
Merged
Merged
Conversation
… clicks - Updated the sandbox IDE image to use code-server 4.132.0 instead of 4.22.0. - Restored mouse click handling for code actions in the quick-fix menu. Signed-off-by: Jean-Luc Davern <jdavern@linuxfoundation.org>
- Added a Java 21-based sandbox IDE image with the Red Hat Java extension installed. - Configured code-server and Maven to use the mounted workspace repository offline. - Added contract tests and documentation for the new image variant. Signed-off-by: Jean-Luc Davern <jdavern@linuxfoundation.org>
- Removed `sshfs_debug` so `sshfs` no longer stayed in the foreground and blocked mount verification. - Deleted the unused file watcher, marker path, and its cleanup handling. BREAKING CHANGE: This commit introduces breaking changes Signed-off-by: Jean-Luc Davern <jdavern@linuxfoundation.org>
relaxdiego
requested changes
Aug 21, 2026
relaxdiego
left a comment
relaxdiego
left a comment
Member
There was a problem hiding this comment.
Thanks for this @jdavv. Can we redo this so that we don't have a separate directory for the Java variant? The thing that concerns me with the current approach is that we're introducting potential drift for what is effectively just 15 or so lines of code.
Some ideas:
- In the same
images/p3-sandbox-ide/, a multi-stage Dockerfile:FROM codercom/code-server:4.132.0 AS base, thenFROM base AS javafor the JDK, the extension, and the two config files. - The java variant is published as
p3-sandbox-ide:v1.4.0-java,:v1.4-java,:v1-java— same repo, variant in the tag, the waypython:3.12-slimworks. - Java config files under a
java/subdirectory (or maybevariants/java?), since both variants ship a file calledsettings.json.
This may mean a change in one or two places in the build process too, so kindly look into that as well.
- Moved the Java IDE variant into `images/p3-sandbox-ide` as a `java` build target. - Split dev and release workflows to build and publish Java-suffixed tags. - Updated CI scripts to build base and Java image variants separately. - Adjusted the Java contract test to validate the shared base image and new tag. - Filtered changed-image detection to skip deleted image roots. Signed-off-by: Jean-Luc Davern <jdavern@linuxfoundation.org>
- Replaced the optional `TARGET` array with a `BUILD_COMMAND` array to avoid Bash 3.2 issues. - Preserved the `--target base` behavior for `p3-sandbox-ide` builds. Signed-off-by: Jean-Luc Davern <jdavern@linuxfoundation.org>
relaxdiego
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 What
Adds p3-sandbox-ide-java
Bumps code-server from 4.22.0 - > 4.132.0
Refactors sshfs-init image
❓ Why
Support the FINOS CDM requirements for IDE in LFWS310 course.
⚡ How to Review
✅ Testing