fix(coordinator): pretty-print startup config logs#3203
Open
nadeemb53 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2826
Note
Medium Risk
Changes how credentials appear in INFO logs; a masking regression could expose secrets in cluster logs, mitigated by dedicated tests.
Overview
Startup and
--check-configs-onlylogging now prints indented, human-readable coordinator config via a newCoordinatorConfig.toPrettyLog()reflection renderer instead of dumping the raw object.Masked values and Web3j private keys render as
***(with byte length for keys). Large maps (smartContractErrors, gas price time-of-day multipliers) collapse to entry counts at INFO with a hint to enable TRACE; full maps move to TRACE-only lines inCoordinatorApp.A regression test loads docker fixture configs and asserts passwords and fixture private-key hexes never appear in either summarized or full pretty output.
Reviewed by Cursor Bugbot for commit af47cc8. Bugbot is set up for automated code reviews on this repo. Configure here.