feat(linea-besu): forced transactions security policy tx selector integration#3262
Open
fluentcrafter wants to merge 3 commits into
Open
feat(linea-besu): forced transactions security policy tx selector integration#3262fluentcrafter wants to merge 3 commits into
fluentcrafter wants to merge 3 commits into
Conversation
ab9bd28 to
555876c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3262 +/- ##
=============================================
- Coverage 76.83% 55.36% -21.47%
+ Complexity 6991 5247 -1744
=============================================
Files 1126 1126
Lines 44644 44644
Branches 5356 5356
=============================================
- Hits 34303 24719 -9584
- Misses 8953 19189 +10236
+ Partials 1388 736 -652
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
555876c to
584fe10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #3136
Checklist
PR.
Note
High Risk
Changes forced-transaction inclusion semantics and block-building interaction with security plugins near deadlines; misconfiguration or the apparent
fromConfigbug could widen force-include behavior unexpectedly.Overview
Integrates chain security policy with forced transaction (FTX) block building so security-plugin rejections can be retried until a configurable window before each FTX’s deadline, when inclusion is forced and security selectors must allow the tx.
A
ChainSecurityPolicyBesu service is added viaLineaChainSecurityPolicy, registered early in the shared Linea plugin and initialized withForcedTransactionPoolService::shallForceIncludeTransaction. Pending FTXs that match the evaluated tx hash and are withinchainSecurityViolationHoldOffBeforeDeadlineblocks of their deadline return true fromshallForceIncludeTransaction, which test/security selectors use to skip blocks (seeFakeChainSecurityPolicyTxValidatorPlugin).LineaForcedTransactionPoolgains the hold-off setting (CLI--plugin-linea-forced-tx-chain-security-violation-before-deadline-inclusion-allowance, default 7200 blocks), mapsCHAIN_SECURITY_RULE_VIOLATEDtoChainSecurityRuleViolation(replacing the old Phylax naming), and treats that outcome as retryable until the deadline window. Acceptance coverage is added inForcedTransactionChainSecurityPolicyTestplus small harness tweaks (block build helpers, optional receipt lookup,ForcedTransactionParamlong deadline overload).Note: The diff includes a
System.out.printlnin selection-result mapping andfromConfigappears to copystatusCacheSizeinto the security allowance field—worth fixing before merge.Reviewed by Cursor Bugbot for commit 584fe10. Bugbot is set up for automated code reviews on this repo. Configure here.