feat(arithmetization): use #[cost:<identifier>] annotation to compute cost of zkc instructions#3284
Open
lorenzogentile404 wants to merge 28 commits into
Conversation
#[cost:<identifier>] annotation to compute cost of zkc instructions#[cost:<identifier>] annotation to compute cost of zkc instructions
|
|
Copilot
AI
changed the title
feat(arithmetization): use
fix(ci): update sample-guest-programs-run workflow to use pinned zkc commit supporting cost annotations
Jun 7, 2026
#[cost:<identifier>] annotation to compute cost of zkc instructions#[cost:<identifier>] annotation to compute cost of zkc instructions
5e3d1f2 to
283431d
Compare
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
…3194) * fix: incorporate isAllowedCircuitID into aggregation FPI * style: comments * fix(contracts): refresh aggregation test fixtures * fix(contracts): align rollup verifier test inputs * docs(contracts): document verifier circuit mask env var --------- Signed-off-by: Arya Tabaie <arya.pourtabatabaie@gmail.com> Co-authored-by: Leo Jeong <dreamerty@postech.ac.kr> Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
…omponent and milestone [skip ci] Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
#3266) * feat(ci): add choice of sequencer-interfaces to maven-release workflow * feat(ci): revise build.gradle of sequencer-interfaces * fix(ci): add repositories in buildScript * feat(ci): disable publish-images-after-run-tests-success-on-main * feat(ci): remove latest docker image tag and retag on unchanged component docker images * chore(ci): rename check_image_tags_exist to compute_commit_tags * chore(ci): change artifactId to sequencer-interfaces Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
* chore(maru): remove unused test * chore(maru): remove unused test Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
…omponent and milestone [skip ci] Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
…3270) * feat: absorb commitments in transcript * chore: regenerate test fixture * fix: update to latest arithmetization elf-to-json script * feat: no-coreutils reversing of zkc input * chore: tamper also public_ext * test: test trace commitment inputs length Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
* feat: add code generation of verifier-side System * feat: add exponentiation with comptime exponent * feat: add vanishing polynomial check * test: add vanishing fixture generation * chore: generate vanishing testdata * ci: check that vanishing testdata is up-to-date * test: add vanishing tests * docs: add some documentation notes * docs: add later integration notes * fix: ensure cancellation points are in allowed ranges Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ivo Kubjas <tsimmm@gmail.com> * fix: check that no coins in round 0 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ivo Kubjas <tsimmm@gmail.com> * fix: explicit error on too large module Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ivo Kubjas <tsimmm@gmail.com> * Revert "fix: ensure cancellation points are in allowed ranges" This reverts commit 5967d8f. --------- Signed-off-by: Ivo Kubjas <tsimmm@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
) * chore(ci): migrate amd64 runners to gha-lfdt-lineth-ss scale sets Signed-off-by: Eloi Manuel <eloi.manuel@consensys.net> * fix(ci): install zkc from LFDT-Lineth/zkc with go-corset fallback go-corset moved to github.com/LFDT-Lineth/zkc. Install the matching module path per ref (new path first, old path fallback) so refs on either side of the rename resolve. Signed-off-by: Eloi Manuel <eloi.manuel@consensys.net> * fix(prover): resolve repo root via .git, not hardcoded dir name GetRepoRootPath matched the literal "linea-monorepo" in the working dir path, breaking after the rename to lineth-monorepo. Walk up to the .git marker instead, so it is independent of the checkout dir name. Signed-off-by: Eloi Manuel <eloi.manuel@consensys.net> --------- Signed-off-by: Eloi Manuel <eloi.manuel@consensys.net> Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
The sample-guest-programs-run workflow was defaulting to `main` for GO_CORSET_REF_FOR_ZKC, which overrides the Makefile's pinned commit. The `main` branch of zkc does not yet support `#[cost:...]` annotations, causing 'unexpected token' errors when running zkc on the .zkc files that use cost annotations introduced in this PR. Fix: default to the same pinned commit used by the Makefile (9f911becf5b02cdd96db75d0fa482c9ececf04c9, tip of 1841-feat-cost-annotation-proposal branch in LFDT-Lineth/zkc) instead of 'main'. Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
The sample-guest-programs-run workflow was defaulting to `main` for GO_CORSET_REF_FOR_ZKC, which overrides the Makefile's pinned commit. The `main` branch of zkc does not yet support `#[cost:...]` annotations, causing 'unexpected token' errors when running zkc on the .zkc files that use cost annotations introduced in this PR. Fix: default to the same pinned commit used by the Makefile (9f911becf5b02cdd96db75d0fa482c9ececf04c9, tip of 1841-feat-cost-annotation-proposal branch in LFDT-Lineth/zkc) instead of 'main'. Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
cdd978f to
1be8069
Compare
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
…pute-cost-of-zkc-instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #3283
Fixes the failing
sample-guest-programs-runGitHub Actions job by correcting the defaultzkccompiler reference used in CI.Root Cause
The
arithmetization-sample-guest-programs-run.ymlworkflow always defaultedGO_CORSET_REF_FOR_ZKCto'main'when triggered by a pull request (no manual input). BecauseGO_CORSET_REF_FOR_ZKCis set as an environment variable, it overrides the Makefile's?=default (9f911becf5b02cdd96db75d0fa482c9ececf04c9). Themainbranch ofLFDT-Lineth/zkcdoes not yet support the#[cost:...]attribute syntax, causingunexpected tokenerrors on every.zkcfile that uses cost annotations.Fix
Changed the workflow's fallback default from
'main'to'9f911becf5b02cdd96db75d0fa482c9ececf04c9'— the same pinned commit already used by the Makefile (tip of the1841-feat-cost-annotation-proposalbranch inLFDT-Lineth/zkc). Custom refs provided viaworkflow_dispatchorworkflow_callcontinue to work as before.Checklist