feat: factorize computed column usage#1831
Open
letypequividelespoubelles wants to merge 6 commits into
Open
Conversation
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR factors out “is-zero indicator” computation used by MIR→AIR lowering so repeated NotEqual constraints over the same expression reuse a single shared computed column (via AIR gadgets), rather than rebuilding equivalent arithmetic subtrees.
Changes:
- Replaces inline
1 - normalise(lhs-rhs)construction inlowerNonEqualityTowith a dedicatedlowerIsZeroIndicatorhelper. - Adds
air_gadgets.IsZeroIndicator, which CSEsiz(e) = 1 - e*inv(e)into a shared computed column with defining vanishings. - Introduces a new trace-filling assignment
assignment.PseudoIzfor computed “is zero” indicator columns.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/ir/mir/lower.go | Routes NotEqual lowering through a new lowerIsZeroIndicator helper (with small-range shortcuts + shift normalisation). |
| pkg/ir/assignment/pseudo_iz.go | Adds a computed-column assignment that fills an iz column with 0/1 based on whether an expression evaluates to zero per-row. |
| pkg/ir/air/gadgets/normalisation.go | Adds IsZeroIndicator gadget that materialises (and reuses) an iz computed column tied to the existing pseudo-inverse gadget. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Comment on lines
+333
to
+345
| // NOTE: the pre-expanded (expand=false) fixtures below are disabled. They | ||
| // embed every computed column verbatim, so any change to the set of computed | ||
| // columns (e.g. the (iz ...) is-zero indicator introduced for control-flow | ||
| // optimisation, see #1793) requires hand-editing each fixture. That | ||
| // maintenance burden outweighs the coverage they add, so they are skipped | ||
| // pending a decision to regenerate or remove them. | ||
| // | ||
| // {"expanded.accepts", true, false, false, "BLS12_377", allOptLevels}, | ||
| // {"expanded.O1.accepts", true, false, false, "BLS12_377", defaultOptLevel}, | ||
| // {"expanded.koalabear_16.rejects", false, false, false, "KOALABEAR_16", defaultOptLevel}, | ||
| // {"expanded.gf_8209.rejects", false, false, false, "GF_8209", defaultOptLevel}, | ||
| // {"expanded.rejects", false, false, false, "BLS12_377", allOptLevels}, | ||
| // {"expanded.O1.rejects", false, false, false, "BLS12_377", defaultOptLevel}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.