Fix precision loss in sendBatch JSON deserialization#2268
Open
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Open
Fix precision loss in sendBatch JSON deserialization#2268Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
…DT-web3j#2141) Fixed precision loss in sendBatch JSON responses by ensuring values are parsed directly as BigDecimal instead of Double. Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Dev10-sys
force-pushed
the
fix/sendbatch-precision-loss
branch
from
03e410e to
6c1554f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes precision loss when parsing floating-point values in sendBatch responses.
Values were previously parsed as double before converting to BigDecimal, causing precision loss.
This change ensures values are parsed directly as BigDecimal.
Where should the reviewer start?
ObjectMapperFactory
Why is it needed?
Precision loss can lead to incorrect financial or blockchain data handling.
This fix ensures exact values are preserved.
This change is safe and does not affect existing behavior except improving precision handling.
Fixes #2141