Add getImplementationName() to generated contract wrappers#2270
Open
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Open
Add getImplementationName() to generated contract wrappers#2270Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
This method returns the generated contract name for better runtime visibility. It addresses issue LFDT-web3j#2078 by providing a non-reflective way to identify the concrete implementation class even when loaded via interfaces. Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
getImplementationName()method to generated contract wrapper classes.This method returns the contract name used during code generation, making it easier to identify which wrapper class is being used.
Where should the reviewer start?
codegen/src/main/java/org/web3j/codegen/SolidityFunctionWrapper.java
Why is it needed?
When loading contracts via interfaces or abstract wrappers, it is not obvious which concrete contract wrapper is being used.
This change improves visibility by exposing the generated contract name directly in the wrapper.
Note: This does not perform runtime implementation detection.
Fixes #2078