fix: correct dynamic array decoding in struct codegen#2272
Open
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Open
fix: correct dynamic array decoding in struct codegen#2272Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Conversation
Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
03288ab to
5fe5c28
Compare
Signed-off-by: Dev10-sys <dev10.sys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where structs containing dynamic arrays (like
address[]) were failing to decode at runtime.Where should the reviewer start?
SolidityFunctionWrapper.javaWhy is it needed?
The generated struct constructors were missing the required type information for dynamic arrays.
Because of this, the ABI decoder could not determine the element type at runtime and threw an error during decoding.
What changed?
@Parameterizedonly for dynamic array fields in struct constructorsStructDynamicArrayDecodeTest) to verify:Result
Structs with dynamic arrays now decode correctly without runtime errors.
Fixes #2001