fix: handle struct and enum prefixes in ABI internalType for code generation#2278
Open
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Open
fix: handle struct and enum prefixes in ABI internalType for code generation#2278Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Conversation
…eb3j#1978) - Update AbiDefinition.NamedType to strip 'struct ' and 'enum ' prefixes from internalType - Fixes issues where JavaPoet generated invalid identifiers during codegen - Add regression test in SolidityFunctionWrapperTest Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Signed-off-by: Dev10-sys <dev10.sys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where code generation fails when ABI contains types prefixed with "struct" or "enum" (for example "struct UserOperation").
Previously, these prefixes were not handled correctly, which led to invalid Java code being generated.
This change cleans the internalType by removing these prefixes so that valid Java class names are produced during code generation.
A test is added to verify the behavior.
Fixes #1978