fix: add websocket fallback for pending transactions when filter is unsupported#2281
Open
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Open
fix: add websocket fallback for pending transactions when filter is unsupported#2281Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Conversation
…j#1941) Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Dev10-sys
force-pushed
the
fix/pending-tx-websocket-fallback
branch
from
cd58360 to
c765a63
Compare
Merged upstream's Async executor lifecycle fix entries (LFDT-web3j#2244, LFDT-web3j#2255) with our pending tx WebSocket fallback entry (LFDT-web3j#1941). Signed-off-by: Dev10-sys <dev10.sys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where pendingTransactionFlowable fails when the node does not support filter-based APIs like eth_newPendingTransactionFilter.
Some nodes (for example BSC or Avalanche) only support websocket subscriptions and return errors when filter APIs are used.
This change adds a fallback to use eth_subscribe (newPendingTransactions) when filter-based polling fails, ensuring pending transactions can still be received over WebSocket connections.
Also improves handling of unexpected result types returned by some nodes.
Fixes #1941