Fix circular reference issue in ethGetLogs filter (#1879)#2288
Open
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Open
Fix circular reference issue in ethGetLogs filter (#1879)#2288Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1879 , where ethGetLogs was failing in some environments due to a circular reference during JSON serialization.
The Filter class had an unused field (thisObj) that was pointing to itself, which caused Jackson to go into an infinite loop and throw a "Direct self-reference leading to cycle" error.
Removed this field since it was not used anywhere, which resolves the issue without affecting existing functionality. Verified with reproduction test and full test run.