put original id stx in log message rather than datum#2
Open
jbclements wants to merge 1 commit intoLLazarek:masterfrom
Open
put original id stx in log message rather than datum#2jbclements wants to merge 1 commit intoLLazarek:masterfrom
jbclements wants to merge 1 commit intoLLazarek:masterfrom
Conversation
Owner
|
Seems like a good direction to me! It probably makes the most sense to change both the "new" and "original" parts of the message to syntax objects, rather than just the "original". If only for consistency's sake, since that's what the rest of the mutators do and what the docs claim (oops). The only additional place I can think of to do this as well would be for constant mutators, which have pretty much the same pattern. And a few tests would be great -- perhaps those could use a small extension of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change puts the original syntax object into the log message rather than the corresponding datum, which allows the receiver of the log message to see what source location was mutated.
It's possible that if this change makes sense, there are a bunch of other changes that would follow, for things other than ids; let me know if that's the case, I'd be happy to broaden the net a bit. Also, maybe I should include tests?
Basically, let me know if you think this is a reasonable direction to go in.