Allow Replay Gain to be modified in a plugin's onStream() protocol handler routine. #1489
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate a track's replay gain value from the Song object rather than a local variable when streaming to a player so that it can be over-ridden by a plugin's registered onStream() protocol handler routine if desired. Signed-off-by: Sam Y <syahres@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate a track's replay gain value from the Song object rather than from a local variable when streaming to a player so that it can be modified by a plugin's registered
onStream()protocol handler routine if desired. This came up in a forum discussion of possible ways to allow the SqueezeDSP plugin to handle replay gain on the server side.