Skip to content

GitHub Issue 778: Track selection loading state on DataRegion so we can disable buttons and prevent another click #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cnathe wants to merge 2 commits into
base: release25.11-SNAPSHOT
Choose a base branch
from
Open

GitHub Issue 778: Track selection loading state on DataRegion so we can disable buttons and prevent another click #7335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8147321
GitHub Issue 778: Track selection loading state on DataRegion so we c…
cnathe Jan 16, 2026
00cb984
GitHub Issue 778: DataRegion selectAll to use jsonData for Ajax reque…
cnathe Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 57 additions & 28 deletions api/webapp/clientapi/dom/DataRegion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ if (!LABKEY.DataRegions) {
* Non-configurable Options
*/
this.selectionModified = false;
this.selectionLoading = false;

if (this.panelConfigurations === undefined) {
this.panelConfigurations = {};
Expand Down Expand Up @@ -1171,19 +1172,11 @@ if (!LABKEY.DataRegions) {
config.selectionKey = this.selectionKey;
config.scope = config.scope || me;

config = _chainSelectionCountCallback(this, config);
// set loading flag for DataRegion, will be cleared in callback
this.selectionLoading = true;
_updateSelectedCountMessage(this);

var failure = LABKEY.Utils.getOnFailure(config);
if ($.isFunction(failure)) {
config.failure = failure;
}
else {
config.failure = function(error) {
let msg = 'Error setting selection';
if (error && error.exception) msg += ': ' + error.exception;
me.addMessage(msg, 'selection');
};
}
config = _chainSelectionCountCallback(this, config);

if (config.selectionKey) {
LABKEY.DataRegion.setSelected(config);
Expand Down Expand Up @@ -3064,6 +3057,7 @@ if (!LABKEY.DataRegions) {
config.success = function(data) {
region.removeMessage('selection');
region.selectionModified = true;
region.selectionLoading = false;
region.selectedCount = data.count;
_onSelectionChange(region);

Expand All @@ -3073,6 +3067,19 @@ if (!LABKEY.DataRegions) {
}
};

var failure = LABKEY.Utils.getOnFailure(config);
config.failure = function(error) {
region.selectionLoading = false;

let msg = 'Error setting selection';
if (error && error.exception) msg += ': ' + error.exception;
config.scope.addMessage(msg, 'selection');

if ($.isFunction(failure)) {
failure.call(config.scope, error);
}
}

return config;
};

Expand Down Expand Up @@ -3363,7 +3370,10 @@ if (!LABKEY.DataRegions) {
var _buttonSelectionBind = function(region, cls, fn) {
var partEl = region.msgbox.getParent().find('div[data-msgpart="selection"]');
partEl.find('.labkey-button' + cls).off('click').on('click', $.proxy(function() {
fn.call(this);
// if one of the buttons is clicked while another action is loading selections, skip the click (the button should also be disabled)
if (!region.selectionLoading) {
fn.call(this);
}
}, region));
};

Expand Down Expand Up @@ -3592,18 +3602,20 @@ if (!LABKEY.DataRegions) {

var _showSelectMessage = function(region, msg) {
if (region.showRecordSelectors) {
const cls = 'labkey-button ' + (region.selectionLoading ? 'disabled ' : '');

if (_isShowSelectAll(region)) {
msg += "&nbsp;<span class='labkey-button select-all'>" + _getSelectAllText(region) + "</span>";
msg += "&nbsp;<span class='" + cls + " select-all'>" + _getSelectAllText(region) + "</span>";
}

msg += "&nbsp;" + "<span class='labkey-button select-none'>Select None</span>";
msg += "&nbsp;" + "<span class='" + cls + " select-none'>Select None</span>";
var showOpts = [];
if (region.showRows !== 'all' && !_isMaxRowsAllRows(region))
showOpts.push("<span class='labkey-button show-all'>Show All</span>");
showOpts.push("<span class='" + cls + " show-all'>Show All</span>");
if (region.showRows !== 'selected')
showOpts.push("<span class='labkey-button show-selected'>Show Selected</span>");
showOpts.push("<span class='" + cls + " show-selected'>Show Selected</span>");
if (region.showRows !== 'unselected')
showOpts.push("<span class='labkey-button show-unselected'>Show Unselected</span>");
showOpts.push("<span class='" + cls + " show-unselected'>Show Unselected</span>");
msg += "&nbsp;&nbsp;" + showOpts.join(" ");
}

Expand Down Expand Up @@ -4081,6 +4093,21 @@ if (!LABKEY.DataRegions) {
_setParameters(region, params, [OFFSET_PREFIX].concat(skipPrefixes));
};

var _updateSelectedCountMessage = function(region) {
// If not all rows are visible and some rows are selected, show selection message
if (region.totalRows && 0 !== region.selectedCount && !region.complete) {
var msg;
if (region.selectedCount === region.totalRows) {
msg = 'All <span class="labkey-strong">' + region.totalRows.toLocaleString() + '</span> rows selected.';
} else if (region.selectionLoading) {
msg = 'Selected <i class="fa fa-spinner fa-pulse" ></i> of ' + region.totalRows.toLocaleString() + ' rows.';
} else {
msg = 'Selected <span class="labkey-strong">' + region.selectedCount.toLocaleString() + '</span> of ' + region.totalRows.toLocaleString() + ' rows.';
}
_showSelectMessage(region, msg);
}
}

var _updateRequiresSelectionButtons = function(region, selectedCount) {

// update the 'select all on page' checkbox state
Expand All @@ -4100,13 +4127,7 @@ if (!LABKEY.DataRegions) {
}
});

// If not all rows are visible and some rows are selected, show selection message
if (region.totalRows && 0 !== region.selectedCount && !region.complete) {
var msg = (region.selectedCount === region.totalRows) ?
'All <span class="labkey-strong">' + region.totalRows.toLocaleString() + '</span> rows selected.' :
'Selected <span class="labkey-strong">' + region.selectedCount.toLocaleString() + '</span> of ' + region.totalRows.toLocaleString() + ' rows.';
_showSelectMessage(region, msg);
}
_updateSelectedCountMessage(region);

// Issue 10566: for javascript perf on IE stash the requires selection buttons
if (!region._requiresSelectionButtons) {
Expand Down Expand Up @@ -4446,6 +4467,11 @@ if (!LABKEY.DataRegions) {
};

LABKEY.DataRegion.selectAll = function(config) {
// GitHub Issue 778: Track selection loading state on DataRegion so we can disable buttons and prevent another click
var region = config.scope;
region.selectionLoading = true;
_updateSelectedCountMessage(region);

var params = {};
if (!config.url) {
// DataRegion doesn't have selectAllURL so generate url and query parameters manually
Expand Down Expand Up @@ -4479,14 +4505,17 @@ if (!LABKEY.DataRegions) {
}

// NOTE: ignore maxRows, showRows, and offset
} else {
params = LABKEY.ActionURL.getParameters(config.url);
config.url = LABKEY.ActionURL.buildURL('query', 'selectAll.api', config.containerPath);
}

LABKEY.Ajax.request({
url: config.url,
method: 'POST',
params: params,
success: LABKEY.Utils.getCallbackWrapper(LABKEY.Utils.getOnSuccess(config), config.scope),
failure: LABKEY.Utils.getCallbackWrapper(LABKEY.Utils.getOnFailure(config), config.scope, true)
jsonData: params,
success: LABKEY.Utils.getCallbackWrapper(LABKEY.Utils.getOnSuccess(config), region),
failure: LABKEY.Utils.getCallbackWrapper(LABKEY.Utils.getOnFailure(config), region, true)
});
};

Expand Down