Fix error importing PySide 1.2.2#47
Fix error importing PySide 1.2.2#47iromero91 wants to merge 1 commit intoLabPy:masterfrom iromero91:master
Conversation
|
Thanks. Yes, this was taken from the IPython project to get PySide and PyQt compatibility. I will take alook. By the why, is PySide alive or it has been abandoned? |
Still no Qt 5 version in sight afaik... |
|
I don't really care much about PyQt because it's not LGPL/BSD compatible. |
Not true. http://www.riverbankcomputing.com/pipermail/pyqt/2014-February/033848.html
(emphasis mine) |
|
I do my best to support both PySide and PyQt. So I will be happy to merge any changes that makes this possible. |
|
Thanks! this fix does work for me, but it might need more work down the line to do something saner. |
|
But I wonder if the #48 is also due to a difference with PySide |
PySide 1.2.2 (at least) doesn't have a
__version__attribute inPySide.QtSvg. Slightly changing the order of imports solves the issue (though if you ask me this code is fairly smelly, there has to be a better solution.)