Harden update links for v2.1.4 - #7
Closed
LabSchool-GR wants to merge 1 commit into
Closed
LabSchool-GR wants to merge 1 commit into
LabSchool-GR wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noreferrerprotection to external links opened in a new tab.The root cause was that update links accepted broader URL schemes and stored values were rendered directly. This change rejects unsafe schemes at input time and safely handles existing records without requiring a migration.
The unrelated local
composer.lockdependency update is deliberately excluded from this PR.Testing
php artisan test— 163 passed, 786 assertionsnpm run build— not required; no compiled frontend assets changedAdditional validation:
composer validate --strict --no-check-publishpassed andgit diff --checkreported no errors.Changelog Draft
Security
Upgrade Notes
Release Notes Check
Upgrade Notes