Add support for custom code generators#66
Merged
ronnie-kaczynski-laerdal merged 13 commits intomainfrom Oct 28, 2025
Merged
Conversation
ronnie-kaczynski-laerdal
requested review from
aleksander-ferkingstad and
sveinse
sveinse
requested changes
Oct 22, 2025
Member
sveinse
left a comment
sveinse
left a comment
There was a problem hiding this comment.
There are some comments to improvements. The gist of the implementation looks good, but there are some minor items that needs to be fixed. Unittest is missing.
sveinse
reviewed
Oct 23, 2025
sveinse
reviewed
Oct 23, 2025
sveinse
reviewed
Oct 23, 2025
sveinse
reviewed
Oct 23, 2025
sveinse
reviewed
Oct 27, 2025
sveinse
reviewed
Oct 27, 2025
sveinse
reviewed
Oct 27, 2025
Member
|
@ronnie-kaczynski-laerdal I see now that the PR was merged with a standard merge and not squash, so all your trials, experiments, debugging commits have made it to its history. This is a public repo, so that was a bit unfortunate with the extra mess 😟 |
sveinse
pushed a commit
that referenced
this pull request
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #65