Repository navigation
ci: test the action against the recorder being shipped - #38
Merged
Merged
Conversation
The action installs a release by tag, so the smoke test could not name the release a commit prepares: it has no assets yet. It named a published tag instead, hardcoded at v0.2.5 when the action landed and never bumped, so preparing v0.2.7 tested a recorder two releases old. Give the action a `recorder` input that takes a binary instead of a release, build the recorder from the checkout, and record with that. The smoke test now exercises the code being shipped rather than a published one, and there is no version in it to go stale. Installing a release is still worth covering, so one further recording does that with the release before this one, and `just release-prepare` keeps that version current the way it already keeps the action's default and the docs example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.