tests: record build systems with a plain toolchain - #39
Merged
Merged
Conversation
The build-system diff tests inherited the whole environment, so a compiler launcher on PATH ran as part of the build and appeared in the recording. That was fine until installing ccache for the wrapper loop test put /usr/lib/ccache in front of cc on the CI runner, and every expectation grew a ccache node. The expectations describe a plain toolchain, so record with one: take the launcher directories off PATH. Tests that want a launcher put one there themselves.
LalitMaganti
added a commit
that referenced
this pull request
Sep 16, 2026
`main` is still red: #39 fixed Make and CMake, which resolve `cc` through `PATH`, but not `meson-ninja`. Meson does not take whatever is in front of the compiler on `PATH`. It goes looking for a `ccache` binary itself, finds `/usr/bin/ccache`, and writes `/usr/bin/ccache cc` into `build.ninja`, so no amount of `PATH` filtering helps. It does leave the compiler alone when it is told which one to use, so the fixture now names it. The fixture also has to apply to the whole test rather than the recording alone, since CMake and Meson resolve the compiler when they configure, which happens before recording starts, and write the result into their build files. Verified on Linux with ccache installed and `/usr/lib64/ccache` first on `PATH`, which is the CI condition: `meson-ninja` and `cmake-ninja` no longer mention ccache at all, and the suite is 43 passed, 2 skipped. The two are deselected there only because that machine's gcc drives `as` through `sh`, which is a pre-existing difference on Fedora and not seen on Ubuntu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. Installing ccache for the wrapper loop test (#36) put/usr/lib/ccachein front ofccon the CI runner, since the Ubuntu packagepopulates that directory and the runner already has it on
PATH. Thebuild-system diff tests inherit the whole environment, so ccache ran as part
of every build and each expectation grew a
ccachenode and anas -> ccache [.o]edge.The expectations describe a plain toolchain, so record with one: take any
launcher directory off
PATHfor these recordings. Tests that want alauncher, such as the wrapper loop test, put one there themselves.
Verified on Linux by reproducing the CI condition with
/usr/lib64/ccachefirst on
PATH:makefails before the change and passes after, and thesuite is 43 passed, 3 skipped with it.