docs(agents): AGENTS.md conventions (auth/authz, test arch, money-path, run-tests) - #255
Open
LamaSu wants to merge 1 commit into
Open
docs(agents): AGENTS.md conventions (auth/authz, test arch, money-path, run-tests)#255LamaSu wants to merge 1 commit into
LamaSu wants to merge 1 commit into
Conversation
…variants + definition-of-done Adds the conventions that would have prevented the #247 signing-identity test breakage (and that codex/agents auto-read from AGENTS.md): - apiGate owns authentication (401); facades own authorization (403) — don't re-check auth in a facade. - gateway test architecture: facade-unit tests wire only the route (no apiGate); integration tests wire apiGate + provisionApiKey + Bearer. Know which layer. - which /api/kernels routes are public vs auth-gated. - money-path invariants: fail closed; SET-ONCE signer = 409; never weaken a security check to pass a test. - definition of done: build + run the affected tests before returning; never imply an unseen green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016MqxjtNMrzb7M23dChjizW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the AGENTS.md conventions written during the #247 work. Doc-only. Auto-read by codex/agents; would have prevented the auth-vs-ownership test breakage. Diff is a single file.