Repository navigation
test(site): Keep event browser checks within their time limit - #80
Merged
Merged
Conversation
Read event links and metadata after each page load. The additional network-idle waits made live preview checks time out while crawling the calendar, even though the server-rendered content was available. Co-authored-by: Codex <noreply@openai.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The Worker candidate's event-page browser checks can complete without timing out on unrelated network activity.
Overview of Changes
Two checks crawl the live event listing to verify Join links and Schema.org metadata. They were waiting for network idle after every page load, even though the links and metadata are present in the server-rendered HTML. With dozens of events, those waits repeatedly exceeded the 30-second test limit and blocked deployment of the already validated membership form.
The checks now read the pages after normal load. The affected tests passed against the candidate URL, with two expected skips because the current event listing has no virtual event that exposes a Join link.
pnpm checkpassed.Follow-ups
None.