Repository navigation
fix(functions): Report mailing list unsubscribe failures - #85
Merged
Merged
Conversation
Leaving the mailing list confirms success only after Beehiiv accepts all linked subscriptions. Provider outages leave the action available so members can retry instead of seeing a false success message. Co-authored-by: Codex <noreply@openai.com>
WillieCubed
had a problem deploying
to
worker-preview
October 2, 2026 17:34 — with
GitHub Actions
Error
WillieCubed
enabled auto-merge (rebase)
October 2, 2026 17:35
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The account's unsubscribe button reports provider failures and lets members retry.
Overview of Changes
Account unsubscribe waits for Beehiiv to accept removal of all linked subscriptions before confirming the change. Network failures, provider outages, and missing configuration produce an error instead of a false success notice.
Regression tests cover failure and retry, normal unsubscribe and rejoin, and the email's one-click POST without cookies or sign-in. The one-click handler rejects forged links and returns a retryable error on provider failure.
pnpm checkpasses.Follow-ups
The fix is merged, but production publishing was skipped: LVBT_WORKERS_PRODUCTION_ENABLED is true while CLOUDFLARE_WORKERS_CANDIDATE_ENABLED is false. The protected staging and explicit promotion workflow is still awaiting activation in the related website task. Publish this fix through that workflow once it is ready.
Verify the production unsubscribe against the existing test account's welcome-email link and confirm its Beehiiv subscription is inactive. The user has been asked for that link.