Obliterate phonos

[The-Shortman]

What does this pull request do?

Removes Phonos from the modpack, as it caused a game-crashing issue, with a very simple one-line patch, however the developers actively refuse to apply the patch and suggest downgrading the Fabric version instead.

Changes made

• Fixes [Bug]: Interacting with Phonos Radio Jukebox crashes server #377 for good

Additional Information

• The mod has been completely removed from the pack - the only remaining item is the Redstone Chip, registered via KubeJS.

Potential Compatibility Issues

• All Phonos blocks and items will be removed from the world and replaced with Air without issue, as I have tested.
• Any existing Redstone Chips will still exist, as the same namespace is now registered by KubeJS. No modification to progression needs to be made.

[The-Shortman]

After some further digging the situation is as follows:

• I was incorrect with my assumption that the Phonos developers actively refuse to merge the patch - the mod is completely abandoned.

• There is an open pull request on the Phonos repository that updates LibGui (the offending dependency) to fix the issue, as mentioned in [Bug]: Interacting with Phonos Radio Jukebox crashes server #377 by @JhouLeal:

  This was actually fixed upstream in Phonos PR #49 by wrapping the painter in a ctx.isClient() check, but the author never compiled or published a new .jar release for 1.18.2 on Modrinth/CurseForge.

It is entirely possible to fork the 1.18 branch of Phonos and maintain it ourselves as a separate project, without removing it from the modpack. In that case, this pull request becomes redundant and can be closed without merging.

It has been suggested that we could patch it via a mixin in Astral Additions, but I think it would be more beneficial to do the fork, as it means the three Fabric 1.18.2 players outside of Astral may benefit from a functional mod on more recent Fabric versions than 0.14.

[The-Shortman]

I have placed this as "Won't Do" for now, as we are planning a major overhaul of our development team structure, and we have mitigations for this crash in place coming in 2.1.5 anyway.

We can revisit this for 2.1.6 after we're more organised.

[ethanicusss]

Our phonos structure replacements should be deleted too, but nothing will be broken if they remain

[The-Shortman]

Ah true, then the better option will probably be to apply the patched version of the mod, since that shouldn't cause those problems.

I do like the mod, and having to remove the radio jukebox was a shame, so having the ability for it be brought back in 2.1.6 would be excellent.

[The-Shortman]

This pull request is incompatible with #770.