Document dynamic group selectors - #3
Merged
Merged
Conversation
Group selectors now intentionally participate in group-policy planning, so the shared model comments must no longer describe them as display-only or policy-irrelevant. Constraint: Runtime wire shape is unchanged; this is contract documentation for existing fields. Rejected: Leave stale display-only comments | future server/dashboard changes would likely regress the intended selector semantics. Confidence: high Scope-risk: narrow Directive: Treat Group.Selector as policy-relevant dynamic membership unless server policy expansion is deliberately changed. Tested: go test ./... Not-tested: No generated proto/code changes because no model shape changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification