Add in-game chat#245
Draft
lhvy wants to merge 6 commits into
Draft
Conversation
Owner
|
Cool contribution! Looks like a solid idea. I'd recommend keeping it as simple as possible (e.g: not keeping history on the server, just relay to clients and forget) to avoid server load and not get too bogged down in it. I'll take a proper look when I get a chance, but nothing jumps out at me taking a quick look. |
Contributor
Author
|
I just noticed the activity over the past 24 hours, thanks for merging #243! I've been quite busy for the past few months and haven't had any time to finish up this PR. I'll hopefully have time for it in the next few weeks... |
lhvy
force-pushed
the
chat
branch
2 times, most recently
from
40a0f3a to
74abee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #56
Adds a chat into the lobbies. Currently WIP, works but needs proper placement and styling.
I'll mark the PR as a draft until I clean up the UI. Any feedback would be appreciated! 🙂