refactor(mcp): integrate evaluator with production service - #7
Open
Lauritz-Timm wants to merge 20 commits into
Open
refactor(mcp): integrate evaluator with production service#7Lauritz-Timm wants to merge 20 commits into
Lauritz-Timm wants to merge 20 commits into
Conversation
9 tasks
Lauritz-Timm
force-pushed
the
feat/mcp-phase-1-evaluation
branch
from
August 17, 2026 07:23
167f5fe to
226ba3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the MCP evaluator from the original standalone
cleanroom/evalpackage into the workspace cratecrates/icm-mcp-eval, while preserving the frozen evaluation contract.What changed
icm_mcp::McpService,ConnectionState,JsonRpcMessage, andicm-storedirectly in-process.This supersedes the original PR description that called the evaluator standalone and product-independent: fixture construction remains evaluator-owned and independent, while the evaluator package intentionally links only production
icm-mcpandicm-storefor its direct service lane.Validation
cargo fmt --all -- --checkcargo clippy --locked --offline --workspace --all-targets -- -D warningscargo test --locked --offline --workspace --no-fail-fast(serial test threads for the existing marginal store performance assertion)verify-design: 294 scenarios, 31 tools, 11 structured toolsUNSUPPORTED_BASELINEThe current candidate branch does not yet expose
icm-cli provider; provider scenarios therefore remain explicitly unsupported in baseline mode and require a provider-capable candidate for full acceptance.