Resolve cusf_sidechain_proto paths from manifest in lib/build.rs#333
Closed
ekulkisnek wants to merge 2 commits into
Closed
Resolve cusf_sidechain_proto paths from manifest in lib/build.rs#333ekulkisnek wants to merge 2 commits into
ekulkisnek wants to merge 2 commits into
Conversation
Made-with: Cursor
Made-with: Cursor
2 tasks
Collaborator
|
Submodule was removed in #348, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
lib/build.rsresolvecusf_sidechain_protofrom manifest-relative paths (workspace root and../), socargoworks whether the submodule lives atcusf_sidechain_proto/next tolib/or the workspace root matches your checkout layout.Changes
lib/build.rs: robust proto root discovery (no brittle single relative path).README.md: submodule comment + maintainer follow-ups (push access; run tests after bumpingcusf_sidechain_proto).Related PRs
bip300301_wallet, cusf_sidechain, coinshift-rs.
Test plan
git submodule update --init --recursivecargo test --workspace --all-features(or CI-equivalent)