Reject transactions that spend a treasury UTXO without creating a new one#369
Merged
Ash-L2L merged 2 commits intoJun 4, 2026
Merged
Conversation
Ash-L2L
approved these changes
Jun 4, 2026
Collaborator
|
Thanks! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per BIP300 a transaction that spends a treasury UTXO as an input and creates no new treasury UTXO as an output is invalid.
https://github.com/LayerTwo-Labs/bip300_bip301_specifications/blob/master/bip300.md#validation-rules-specification
handle_m5_m6buildsctip_spends(treasury inputs) but only consults it inside the loop overnew_ctips(treasury outputs). A tx that spends a treasury UTXO and creates no new treasury output never enters that loop, so it returnsOk(None)and is ignored. OP_DRIVECHAIN is anyone-can-spend, so anyone could drain a sidechain's treasury this way.This adds the missing check. Every spent treasury must have a corresponding new treasury output, otherwise the tx is invalid. Block-level rejection of the invalid tx is handled by #365 (which propagates non-fatal tx errors instead of
skipping them).