Fail sidechain proposals that can no longer reach the activation threshold#372
Open
1440000bytes wants to merge 2 commits into
Open
Fail sidechain proposals that can no longer reach the activation threshold#3721440000bytes wants to merge 2 commits into
1440000bytes wants to merge 2 commits into
Conversation
torkelrogstad
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP300 lists four conditions under which a sidechain proposal fails. The code only implemented the two max-age cutoffs; it omitted the two MAX_FAILS early-failure conditions.
bip300301_enforcer/lib/validator/task/mod.rs
Lines 276 to 277 in cbc1f80
A proposal should fail as soon as it has accumulated enough non-ack blocks that it can no longer reach the activation threshold in its remaining window (max_fails = max_age - threshold; 201 for unused, 13150 for used). Otherwise a doomed proposal lingers until its max age and because
handle_m1ignores a re-proposal of any still-existing proposal, two enforcers can diverge on whether a sidechain activates during that window.Fix
Fail a proposal when
age > max_fails && (age - vote_count) >= max_fails, derived from the existing thresholds.