Repository navigation
truthcoin: support truthcoin 0.20.0 - #2493
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
b67e926 to
13e4c86
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13e4c86a94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // transaction, and the block that carries it. Every other CUSF chain returns | ||
| // the transaction alone. | ||
| // nodeTxEnvelope is what get_transaction returns on thunder, photon and | ||
| // truthcoin: the transaction, and the block that carries it. Every other CUSF |
There was a problem hiding this comment.
When Truthcoin 0.20 returns a confirmed transaction in the new {block_hash, tx} envelope, nodeTransaction takes the envelope.BlockHash != nil branch and never calls get_transaction_info, even though that response is the only source of fee_sats. Consequently, the explorer displays a zero fee for every confirmed Truthcoin transaction; retrieve the transaction info for its fee even when confirmation data comes from the envelope.
Useful? React with 👍 / 👎.
1 participant
This PR moves BitWindow, the truthcoin app and drivechaind to the truthcoin 0.20.0 RPC names, JSON shapes and start flags from LayerTwo-Labs/truthcoin-dc#41, and must merge together with the 0.20.0 release.